L-1
Finding
L-1: Early return on zero `amountMin` silently skips deposit/skim operations
Description:
In verifyAmountMinAndDeposit and verifyAmountMinAndSkim, an early return occurs when amountMin == 0:
if (amountMin == 0) return;
This silently skips the deposit/skim operation entirely without any revert or indication to the caller. While 99.9% of swaps will specify amountMin > 0, callers may not expect that passing 0 results in no deposit rather than a deposit with no slippage protection.
Impact:
Low. Unexpected behavior where zero amountMin silently skips operations instead of performing them without slippage checks. Zero share errors would revert at the vault level anyway.
Recommendation:
Remove the early return checks, allowing the vault to handle edge cases and revert if necessary.
Developer Response:
Fixed in commit b6046f4.